Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR appsmithorg#41352

Type: Clean (correct implementation)

Original PR Title: feat: Regenerate git SSH key
Original PR Description: ## Description
This PR introduces the ability to regenerate SSH deploy keys for Git-connected applications. This feature allows users to generate new deploy keys when their existing keys are invalid, expired, or need to be rotated.

Design

Changes

Core Features

  • Generate Deploy Key Modal: New modal component (GenerateDeployKeyModal) that allows users to generate and configure new SSH deploy keys
  • Danger Zone Integration: Added "Generate deploy key" button in the Git Settings Danger Zone for easy access to the regeneration flow
  • Invalid Key Warning: Added warning component (InvalidKeyWarning) that detects invalid deploy keys (error code AE-GIT-4032) and prompts users to regenerate
  • API Integration: New API endpoint integration (updateGeneratedSSHKeyRequest) to persist the most recent regenerated SSH key on the backend

UI/UX Improvements

  • Settings modal now closes automatically when opening the generate deploy key modal
  • Updated deploy key generation message to fit in 2 lines in the modal's UI
  • Added proper loading states and error handling throughout the flow
  • Statusbar component integration for showing progress during key regeneration

Component Reorganization

  • Moved common Git UI components from ConnectModal/ConnectInitialize to components/common:
    • AddDeployKey.tsx
    • CopyButton.tsx
    • constants.ts
    • types.ts
  • Renamed common.tsx to GitUIComponents.tsx for better clarity

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/19032400320
Commit: 5f62a52
Cypress dashboard.
Tags: @tag.Git
Spec:


Mon, 03 Nov 2025 12:02:30 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Deploy key generation flow added to Git settings with a modal, UI to generate/update SSH deploy keys, and in-settings prompt when a key is invalid.
    • Settings now include a direct link to open Git settings from debugger entries.
  • Debugger Improvements

    • Debugger recognizes Git entities with a Git icon/link.
    • Invalid deploy-key issues are logged and surfaced as error-level debugger entries.

Original PR URL: appsmithorg#41352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants